Skip to content

feat: allowing regex on tags passed (simplify expressions) #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorgepiloto merged 5 commits into from
Jan 23, 2026
Merged

feat: allowing regex on tags passed (simplify expressions) #1118

jorgepiloto merged 5 commits into from
Jan 23, 2026

Conversation

@RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Jan 23, 2026

Using regex on hk-package-clean-except action. Backwards compatible while allowing regex on input for tags

@RobPasMue RobPasMue requested a review from a team as a code owner January 23, 2026 07:13
@github-actions github-actions bot added the enhancement General improvements to existing features label Jan 23, 2026
@RobPasMue
Copy link
Member Author

RobPasMue commented Jan 23, 2026 •
edited
Loading

@ansys/pyansys-core - I'd appreciate a review on this one

@RobPasMue RobPasMue self-assigned this Jan 23, 2026
@RobPasMue
Copy link
Member Author

RobPasMue commented Jan 23, 2026 •
edited
Loading

Works fine - see https://github.com/ansys/pyansys-geometry/actions/runs/21278985229/job/61244286569#step:2:53

image

@RobPasMue
Copy link
Member Author

RobPasMue commented Jan 23, 2026

CI failure is unrelated - appears to be linked to choco instabilities reported. Suggesting to merge

AlejandroFernandezLuces
AlejandroFernandezLuces approved these changes Jan 23, 2026
View reviewed changes
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm just wondering, why is it needed to have the Python script as a string instead of a separate file? Is not possible to use an external script when using the action in another repo?

@RobPasMue
Copy link
Member Author

RobPasMue commented Jan 23, 2026

LGTM, I'm just wondering, why is it needed to have the Python script as a string instead of a separate file? Is not possible to use an external script when using the action in another repo?

Yep we can do that - it's just the "old way" it was implemented. Once #1116 is merged I will update this PR and move it to the python-utils folder. Good idea!

@jorgepiloto jorgepiloto merged commit 45deca1 into main Jan 23, 2026
92 of 95 checks passed
@jorgepiloto jorgepiloto deleted the feat/accepting-regex branch January 23, 2026 09:31
@jorgepiloto
Copy link
Member

jorgepiloto commented Jan 23, 2026

Thanks for expanding this, @RobPasMue.

@RobPasMue
Copy link
Member Author

RobPasMue commented Jan 23, 2026

I'll do the modification suggested by @AlejandroFernandezLuces in a separate PR

moe-ad pushed a commit that referenced this pull request Feb 9, 2026
@RobPasMue @pyansys-ci-bot @moe-ad
feat: allowing regex on tags passed (simplify expressions) (#1118)
8c472d8 
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlejandroFernandezLuces AlejandroFernandezLuces AlejandroFernandezLuces approved these changes

@jorgepiloto jorgepiloto jorgepiloto approved these changes

Assignees

@RobPasMue RobPasMue

Labels

enhancement General improvements to existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RobPasMue @jorgepiloto @AlejandroFernandezLuces @pyansys-ci-bot