XCH-2897 coppa support

[anthonyjl92]

Type of change

• Bugfix

• Feature

• New bidder adapter

• Code style update (formatting, local variables)

• Refactoring (no functional changes, no api changes)

• Build related changes

• CI related changes

• Does this change affect user-facing APIs or examples documented on http://prebid.org?

• Other

Description of change

Other information

[carlosfelix]

in order to make the title more readable, my suggestion is to change it to something like

it('should call endpoint with an enabled coppa signal', () => {

thoughts?

same for the other one

[anthonyjl92]

yep, will make this change

[carlosfelix]

what if you just add the coppa signal when it's present.

e.g.

const coppaValue = config.getConfig('coppa');

if (coppaValue !== undefined) {
  ttxRequest.regs.coppa = Number(!!coppaValue);
}

wouldn't that help to reduce the .withCoppa(0) calls in the specs and also be more in sync with other signals that we add to the request only when they are present such as the us_privacy and gpp. LMK what you think about this suggestion.

[carlosfelix]

most likely getConfig('coppa') will return undefined, that will be the common scenario, so I think you could adjust this spec to cover this case as well.. my recommendation is the following.

e.g.

context('when coppa is NOT enabled', function() {
      it('returns corresponding server requests with coppa: 0', function() {
        [false, undefined].forEach((value)=> {
          sandbox.stub(config, 'getConfig').withArgs('coppa').returns(value);
           // the rest of the spec
        })
        

Although this "undefined" case scenario might not be needed if we only add coppa to the request when the value is different than undefined, like I am suggesting in the other comment.

[carlosfelix]

here we don't have to check for an undefined coppa, since getCoppa always returns a boolean.