Open
Conversation
and rename fn
- rewrite majority of R code to be more consistent and logically coherent incl. lots of renamings - improve QSS installation for Windows by checking file access permissions; display a warning with more infos if permissions are insufficient (not admin) - improve QSS installation for Linux: ask interactively for administrator credentials by calling [Polkit](https://en.wikipedia.org/wiki/Polkit)'s #' [`pkexec`](https://www.freedesktop.org/software/polkit/docs/latest/pkexec.1.html) and perform all admin-level actions in one go - improve/extend documentation; should be less confusing now for users who didn't know about QSS
(obsolete leftover)
(wasn't really intentional to use it😅)
this is performed by Pandoc under the hood and only available in RStudio 1.4+, see https://rstudio.github.io/visual-markdown-editing/
and overhaul it to be more clear/precise
(RStudio's built-in auto-formatting broke the proper Markdown syntax 😒)
Contributor
Author
|
@anthonynorth Did you have a chance to look at this PR? |
i.a. updates related to R 4.2.0's doc enhancements, cf. https://developer.r-project.org/Blog/public/2022/04/08/enhancements-to-html-documentation/index.html
(default in upcoming RStudio)
maybe these `GEL-OVUB*` classes are not really permanent and thus a dead end?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rewrite majority of R code to be more consistent and logically coherent incl. lots of renamings; use consistent style (mostly tidyverse-compliant; but line width @ 160)
improve QSS installation for Windows by checking file access permissions; display a warning with more infos if permissions are insufficient (not admin)
improve QSS installation for Linux: ask interactively for administrator credentials by calling Polkit's
pkexecand perform all admin-level actions in one goimprove/extend documentation; should be less confusing now for users who haven't heard about RStudio's QSS files before
improve/extend package title and description
update and convert README to R Markdown format (and generate
README.mdusingdevtools::build_readme()) to make use of RStudio 1.4's new Markdown canonicalizationneeds testing on Windows! otherwise package should be more-or-less ready for a CRAN submission at this point (though we might want to tackle other issues first)