feat: unified checkDependencies API returning SandboxDependencyCheck #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename DependencyCheck -> SandboxDependencyCheck
- checkDependencies() now returns { errors, warnings } instead of boolean
- Mac: always returns { errors: [], warnings: [] } (no system deps)
- Linux: bwrap/socat missing -> errors, seccomp missing -> warnings
- Unsupported platform: returns errors
- Remove checkLinuxDependencies and getLinuxDependencyStatus from public API
- Remove ripgrep check from checkDependencies (bundled, not a system dep)
- Add comprehensive tests for dependency checking
ollie-anthropic
force-pushed
the
ollie/unified-dependency-check
branch
from
a63b33c to
ad5d35c
Compare
…rrect arch values - Replace hasLinuxSandboxDependenciesSync with checkLinuxDependencies - Fix process.arch comparisons: x86_64 -> x64, aarch64 -> arm64 - Remove duplicate arch conditions
dylan-conway
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies the sandbox dependency checking API to a single cross-platform function that returns structured results. This allows us to display to the user information about seccomp availability.
Changes
DependencyCheck→SandboxDependencyCheckcheckDependencies()now returns{ errors: string[], warnings: string[] }instead ofbooleanerrors: Required deps missing (bwrap/socat on Linux, unsupported platform)warnings: Optional deps missing (seccomp filter){ errors: [], warnings: [] }— uses built-in sandbox-execcheckLinuxDependencies,getLinuxDependencyStatus