fix: support WSL2 sandboxing, reject WSL1 #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WSL2+ uses the same bubblewrap sandboxing as Linux, so it should be supported. WSL1 does not support bubblewrap properly. - Add getWslVersion() to detect WSL version from /proc/version - Update isSupportedPlatform() to check for WSL1 and reject it - Remove 'wsl' from Platform type (getPlatform returns 'linux' for WSL) - Update comments to clarify Linux/WSL glob pattern handling
ollie-anthropic
commented
Jan 21, 2026
| * Get the WSL version (1 or 2+) if running in WSL. | ||
| * Returns undefined if not running in WSL. | ||
| */ | ||
| export function getWslVersion(): string | undefined { |
Collaborator
Author
There was a problem hiding this comment.
took this from claude-cli code :)
ollie-anthropic
force-pushed
the
ollie/fix-wsl-platform-check
branch
from
254d82e to
d612cb7
Compare
ollie-anthropic
commented
Jan 21, 2026
| enableLogMonitor?: boolean, | ||
| ): Promise<void> | ||
| isSupportedPlatform(platform: Platform): boolean | ||
| isSupportedPlatform(): boolean |
Collaborator
Author
There was a problem hiding this comment.
api changed here but i really think it's unused and this is cleaner
ant-kurt
reviewed
Jan 21, 2026
| const supportedPlatforms: Platform[] = ['macos', 'linux'] | ||
| return supportedPlatforms.includes(platform) | ||
| function isSupportedPlatform(): boolean { | ||
| const platform = getPlatform() |
Collaborator
There was a problem hiding this comment.
This could add latency due to containing a sync FS call (reading the /proc/version)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WSL2+ uses the same bubblewrap sandboxing as Linux, so it should be supported. WSL1 does not support bubblewrap properly.
Changes
getWslVersion()to detect WSL version from/proc/versionisSupportedPlatform()to check for WSL1 and reject itgetPlatformreturns 'linux' for WSL)Testing