feat: implement typescript declaration files#379
Draft
earthernsence wants to merge 4 commits intoantimatter-dimensions:masterfrom
Draft
feat: implement typescript declaration files#379earthernsence wants to merge 4 commits intoantimatter-dimensions:masterfrom
earthernsence wants to merge 4 commits intoantimatter-dimensions:masterfrom
Conversation
Member
Author
|
Also worth mentioning: on my fork, I also tested using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to close issue #150 and replace pull request #204. To do this, we can simply use the native TypeScript compiler to generate the declaration files, which seems to work pretty much identically to the
bilichanges used in #204, but it (to me) feels a bit more natural.I guess the other thing that would need to be figured out before this is merged is how we want community notations to work. Currently, they are made to be installed separately from the main package, which is mostly fine for most use cases. It becomes a bit more complicated when there are types involved (and if somebody wanted to use the community notations in, say, a React/Vue application that wants to use the NPM versions of the packages).
As a note: the
build-test.ymlfile can be removed; it was simply how I tested that the build wouldn't fail because it wasn't working on my machine.