Skip to content

queue.c: avoid overflow #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunheehnus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

queue.c: avoid overflow #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/queue.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,8 @@ void needJobsForQueue(queue *q, int type) {

if (now - q->needjobs_bcast_time > bcast_delay) {
q->needjobs_bcast_time = now;
q->needjobs_bcast_attempt++;
if (bcast_delay != NEEDJOBS_BCAST_ALL_MAX_DELAY)
q->needjobs_bcast_attempt++;
/* Cluster-wide broadcasts are just to discover nodes,
* ask for a single job in this case. */
clusterSendNeedJobs(q->name,1,server.cluster->nodes);
Expand All @@ -493,7 +494,8 @@ void needJobsForQueue(queue *q, int type) {
num_responders > 0)
{
q->needjobs_adhoc_time = now;
q->needjobs_adhoc_attempt++;
if (adhoc_delay != NEEDJOBS_BCAST_ADHOC_MAX_DELAY)
q->needjobs_adhoc_attempt++;
clusterSendNeedJobs(q->name,to_fetch,q->needjobs_responders);
}
}
Expand Down Expand Up @@ -581,6 +583,7 @@ void receiveNeedJobs(clusterNode *node, robj *qname, uint32_t count) {
* we have, but always at least a single job. */
if (qlen < count*2) replyjobs = qlen/2;
if (replyjobs == 0) replyjobs = 1;
if (replyjobs > NEEDJOBS_MAX_REQUEST) replyjobs = NEEDJOBS_MAX_REQUEST;

job *jobs[NEEDJOBS_MAX_REQUEST];
for (j = 0; j < replyjobs; j++) {
Expand Down