Removed useless gotos, using 5 less LOC and making the code more readable
#108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the
gotos statements in this file make sense, particularly for reducing the LOC count.goto failedandgoto fatalthough, in my opinion, do not make sense.What's the point of having a
gotostatement that handles a failure by simply returning-1? Simply doreturn -1;instead without thegoto.Also, the line
errno = ENOTTY;is useless and confusing:errnoto a specific value when an error happens, buterrnoshould already be set to the correct value (the one that represents the encountered error),errnois not used.This is confusing. Again, just do
return -1;instead without thegoto.(with love from Cremona <3 @antirez )