Conversation
This enables the user to enforce maximum assertion message (name) length
|
|
||
| namespace antithesis::internal { | ||
| namespace { // Anonymous namespace which is translation-unit-specific; certain symbols aren't exposed in the symbol table as a result | ||
| enum msg_name_e { msg_name }; |
There was a problem hiding this comment.
suggestions for better name here are welcome.
I agree there are some conventions that one should follow in assertion messages to provide a good experience, This is still great feedback, and we'll definitely want to improve our documentation to help people follow good conventions in authoring assertions. I'll keep this open for new ideas! |
We have new users defining their own instrumentation points, and they have started using some very long messages, unaware that this may cause readability issues in report and also that these names are stuck "forever" (or until report history is truncated).
This change will enable us to enforce maximum assertion message (name) length.
I tested this with
I am not planning to bring this functionality to polyfills, as it would bring lots of extra assumptions into what polyfills are allowed (or not) to do.