Jess/507 grantpermission form

[jesscmoore]

Pull Request Details

Merge after PRs for public/auth and success colors

What issue does this PR address

• Moves the permission granting part of GrantPermissionUi() to a dialog. The top part of GrantPermissionUi() is replaced by a Share Resource button, on pressed it displays a GrantPermissionForm() dialog where the user selects recipient type, webids and access permissions. On pressing Grant Permission button in dialog, the new/updated permission is granted or fails, with same UX.
• This adds functionality for the developer, as the UI of grant permission form can be more easily rearranged to improve it and fix responsiveness on small displays. And the permission table can also be redesigned to allow search, tooltips, history, etc.
• The permission table has not been changed, just moved into a stateful widget.
• Fixes linting (locmax) - reducing size of GrantPermissionUi()
• Improved documentation

Associated Issue

• This PR relates to issue SOLIDPOD: migrate grant permission part of GrantPermissionUI to form #507

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

In notepad on macOS, select a note, click share icon, shared to individual and group recipients, revoked recipients.

Checklist

Complete the check-list below to ensure your branch is ready for PR.

• Screenshots included in linked issue #
• Changes adhere to the style and coding guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• Any dependent changes have been merged and published in downstream modules
• The update contains no confidential information
• The update has no duplicated content
• No lint check errors are related to these changes (make prep or flutter analyze lib)
• Integration test dart test output or screenshot included in issue #
• I tested the PR on these devices:
  • Android
  • iOS
  • Linux
  • MacOS
  • Windows
  • Web
• I have identified reviewers
• The PR has been approved by reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

• Merge dev into the this branch
• Resolve any conflicts
• Add a one line summary into the CHANGELOG.md
• Push to the git repository and review
• Merge the PR into dev

[jesscmoore]

Also tested in solidpod DemoPod, add delete Permission form a Specific Resource working, but add/delete Permission from Any Resource giving an error. Suspected this might happen and will investigate.

[ERROR:flutter/runtime/dart_vm_initializer.cc(40)] Unhandled Exception: 'package:solidpod/src/solid/grant_permission_ui.dart': Failed assertion: line 304 pos 12: 'pdata != null': is not true.

[jesscmoore]

Demopod permission granting exercise 'add/delete Permission from Any Resource' is now working too. However the on permission callback demo is failing in loading stage with Unknown error:

[gjwgit]

Looks attractive - thanks @jesscmoore. Tested on NotePod. Noting above issues to be resolved - should we merge this and break the others out as separate issues to fix?

[jesscmoore]

Noticed that the Demopod permission callback demo error relates to unchanged code. Tested this demo on dev branch, and discovered the permission callback demo error is a pre-existing error. Adding an issue for it.

[jesscmoore]

Looks attractive - thanks @jesscmoore. Tested on NotePod. Noting above issues to be resolved - should we merge this and break the others out as separate issues to fix?
@gjwgit Let me just resolve the conflicts with dev, then we can merge (noting latest comment that demopod error is not related to this PR).

[gjwgit]

Thanks @jesscmoore Once the conflicts are resolved, do the merge!

[jesscmoore]

@gjwgit Resolved conflicts, updated changelog. This PR is ready for merging. Thanks for your quick reviews of the 3 PRs today.