Skip to content

Tony/548 logout #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gjwgit merged 5 commits into from
Jan 22, 2026
Merged

Tony/548 logout #174

gjwgit merged 5 commits into from
Jan 22, 2026

Conversation

@tonypioneer
Copy link
Collaborator

@tonypioneer tonypioneer commented Jan 21, 2026

Pull Request Details

What issue does this PR address

  • Fixed the missing logout button issue.

Associated Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Build and run the app.

Checklist

Complete the check-list below to ensure your branch is ready for PR.

  • Screenshots included in linked issue SOLIDUI: Missing logout button solidpod#548
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

@tonypioneer tonypioneer requested a review from gjwgit January 21, 2026 14:10
@tonypioneer tonypioneer self-assigned this Jan 21, 2026
@tonypioneer tonypioneer linked an issue Jan 21, 2026 that may be closed by this pull request
SOLIDUI: Missing logout button anusii/solidpod#548
Closed
@tonypioneer tonypioneer changed the base branch from dev to tony/167_preferences January 21, 2026 14:10
Base automatically changed from tony/167_preferences to dev January 21, 2026 23:15
gjwgit
gjwgit approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@gjwgit gjwgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with bookoflife. All good. Thanks @tonypioneer. Once the PR conflicts are resolved we can merge.

@tonypioneer
Merge branch 'dev' of https://github.com/anusii/solidui into tony/548…
b412f5e 
…_logout

# Conflicts:
#	lib/src/widgets/solid_scaffold_appbar_actions.dart
#	lib/src/widgets/solid_scaffold_appbar_builder.dart
#	lib/src/widgets/solid_scaffold_widget_builder.dart
@gjwgit gjwgit merged commit 9a9c798 into dev Jan 22, 2026
20 checks passed
@gjwgit gjwgit deleted the tony/548_logout branch January 22, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gjwgit gjwgit gjwgit approved these changes

Assignees

@tonypioneer tonypioneer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SOLIDUI: Missing logout button

3 participants

@tonypioneer @gjwgit