Fix bluriness when there is multiple different outputs scaling values#46
Merged
any1 merged 2 commits intoany1:masterfrom Feb 12, 2025
Merged
Conversation
stacyharper
force-pushed
the
wbarraco/push-vmprxsuskvpy
branch
from
ef15eab to
500a648
Compare
Contributor
Author
|
I'm a bit annoyed by this link2, but is there a better way? |
any1
reviewed
Feb 10, 2025
Owner
any1
left a comment
any1
left a comment
There was a problem hiding this comment.
I believe "Fix blurriness when there are multiple output scaling values" is the more conventional way of saying this?
stacyharper
force-pushed
the
wbarraco/push-vmprxsuskvpy
branch
2 times, most recently
from
37c5c4c to
5ee08a6
Compare
Contributor
Author
I reworked those patch this way, and applied your recommandations. |
To do so, we filter outputs that the surface has not entered when computing the max scale on the list.
This is available on version 6 or later. So we keep our own code to be retro-compatible.
stacyharper
force-pushed
the
wbarraco/push-vmprxsuskvpy
branch
from
5ee08a6 to
61b3086
Compare
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #36 (comment)