updated contract to use a single signer' #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahgwai
reviewed
Jun 10, 2020
| * @param _signature Signer's signature | ||
| */ | ||
| function verify(bytes memory _callData, | ||
| function replayProtection(address _signer, |
Collaborator
There was a problem hiding this comment.
this should be called checkAndUpdateReplayProtection
| } | ||
|
|
||
| /// @dev Return owner. | ||
| function getOwner() internal view returns (address) { |
Collaborator
There was a problem hiding this comment.
Why do we need this funtion? Cant we just call owner?
| @@ -40,10 +34,16 @@ contract ProxyAccount is ReplayProtection, BatchInternal { | |||
| bytes memory _signature) public returns (bool, bytes memory) { | |||
|
|
|||
| // Assumes that ProxyAccountDeployer is ReplayProtection. | |||
Collaborator
There was a problem hiding this comment.
Is this comment out of date?
| * @param _replayProtectionAuthority Identify the Replay protection, default is address(0) | ||
| * @param _signature Signature from signer | ||
| */ | ||
| function getSigner(bytes memory _encodedCallData, bytes memory _replayProtection, address _replayProtectionAuthority, |
Collaborator
There was a problem hiding this comment.
As mentioned in the chat, I think we should use this everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.