Fix #10: workaround for handle unsorted zip entry.#11
Fix #10: workaround for handle unsorted zip entry.#11Bedotech wants to merge 1 commit intoaogail:masterfrom
Conversation
|
Thanks for the PR. Can you add a test case that involves a zip file with this issue? I also wonder whether manually creating the parent directory in this way could interfere with metadata about the parent in the zip file. |
|
Hi @aogail, the tests work well? i try to execute the procedure as described in the Al the output is: And no VM is started.can you please tell me whats kind of test and where you expect to be executed? |
|
I meant that this is new behavior so it deserves a new integration test. The current integration tests use Test Kitchen to spin up a VM and extract a known zip file, then assert that the expected files came out. The integration tests may be executed using A new test case to verify this new behavior would involve creating a zip file that triggers the behavior described in #10 and verifying that the zipfile resource extracts it correctly. I would also like to confirm that, if directory entries have metadata (modification time, permissions, etc.), they are correctly handled in this out of order case. |
@aogail please review this is to handle case as #10 !