Changes for making PyMunin Python 3 compatible#52
Open
penguinpee wants to merge 5 commits intoaouyar:masterfrom
Open
Changes for making PyMunin Python 3 compatible#52penguinpee wants to merge 5 commits intoaouyar:masterfrom
penguinpee wants to merge 5 commits intoaouyar:masterfrom
Conversation
Reapplied changes neded for Python3 compatibility with 2to3
Merged changes suggested by Python 2to3 tool
* dict has_key -> key in dict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm in the process of writing an nftables plugin for Munin and came across PyMunin. Installing it through pip failed due to Pyhton 2 syntax in
setup.pyandpymunin/__ini__.py.With this PR the module should install in a Python 3 environment.
I installed it locally from the repository root using:
I did not check any of the plugins for Python 3 compatibility.