Skip to content

Conversation

@versha890
Copy link
Contributor

This PR fixes the issue with the OpenGraph article:modified_time meta tag.
Previously, regenerating the site updated the modification time incorrectly for all posts.
Now, it uses .Params.lastmod to reflect the actual last modified date set in the post front matter.

##Changes

Updated _partials/opengraph.html:
{{ with .Params.lastmod }}
<meta property="article:modified_time" content="{{ . | time.Format "2006-01-02T15:04:05Z07:00" }}" />
{{ end }}

Copy link
Member

@choo121600 choo121600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like there are quite a few unnecessary changes.

I’ve noticed similar patterns across several of your PRs.
A bit of additional review yourself before submitting could help improve the overall quality.

@versha890
Copy link
Contributor Author

Thank you for the feedback.
I understand your point and I’ll be more careful with self-review before submitting future PRs.
I’ll also recheck this PR and reduce any unnecessary changes where possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants