Skip to content

Updated _DAG_HASH_ATTRS to use timetable instead of schedule #59811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justinpakzad wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −3
Open

Updated _DAG_HASH_ATTRS to use timetable instead of schedule #59811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
172829c
Updated _DAG_HASH_ATTRS to use timetable instead of schedule
justinpakzad Dec 26, 2025
cff736b
added @attrs.define for simple timetable classes
justinpakzad Dec 30, 2025
0ab5d60
prek fix formatting issue
justinpakzad Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions task-sdk/src/airflow/sdk/definitions/dag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,7 @@
"fileloc",
"template_searchpath",
"last_loaded",
"schedule",
# TODO: Task-SDK: we should be hashing on timetable now, not schedule!
# "timetable",
"timetable",
}
)

Expand Down
5 changes: 5 additions & 0 deletions task-sdk/src/airflow/sdk/definitions/timetables/simple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,12 @@

from __future__ import annotations

import attrs

from airflow.sdk.bases.timetable import BaseTimetable


@attrs.define
class NullTimetable(BaseTimetable):
"""
Timetable that never schedules anything.
Expand All @@ -30,6 +33,7 @@ class NullTimetable(BaseTimetable):
can_be_scheduled = False


@attrs.define
class OnceTimetable(BaseTimetable):
"""
Timetable that schedules the execution once as soon as possible.
Expand All @@ -38,6 +42,7 @@ class OnceTimetable(BaseTimetable):
"""


@attrs.define
class ContinuousTimetable(BaseTimetable):
"""
Timetable that schedules continually, while still respecting start_date and end_date.
Expand Down