Skip to content

Fix: Make sqlalchemy optional in Drill provider #59916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NewSmoke38 wants to merge 1 commit into from
+10 −2
Closed

Fix: Make sqlalchemy optional in Drill provider #59916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions providers/apache/drill/src/airflow/providers/apache/drill/hooks/drill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,11 @@

from collections.abc import Iterable
from typing import TYPE_CHECKING, Any, NoReturn

from sqlalchemy import create_engine
from airflow.exceptions import AirflowOptionalProviderFeatureException
try:
from sqlalchemy import create_engine
except ImportError:
create_engine = None

from airflow.providers.common.sql.hooks.sql import DbApiHook

Expand Down Expand Up @@ -52,6 +55,11 @@ class DrillHook(DbApiHook):
def get_conn(self) -> PoolProxiedConnection:
"""Establish a connection to Drillbit."""
conn_md = self.get_connection(self.get_conn_id())

if create_engine is None:

Copy link
Collaborator

@sunank200 sunank200 Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

raise AirflowOptionalProviderFeatureException("The 'sqlalchemy' library is required to use this hook.")
Copy link
Collaborator

@sunank200 sunank200 Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
raise AirflowOptionalProviderFeatureException("The 'sqlalchemy' library is required to use this hook.")
raise AirflowOptionalProviderFeatureException(
"sqlalchemy is required for SQL filter clause generation. "
"Install it with: pip install 'apache-airflow-providers-drill[sqlalchemy]'"
)


creds = f"{conn_md.login}:{conn_md.password}@" if conn_md.login else ""
database_url = (
f"{conn_md.extra_dejson.get('dialect_driver', 'drill+sadrill')}://{creds}"
Expand Down
Loading