Skip to content

Conversation

@zanmato1984
Copy link
Contributor

@zanmato1984 zanmato1984 commented Dec 24, 2025

Rationale for this change

When dispatching binary arithmetic and comparison kernels, we do a special casting ahead for decimal arguments. If one argument is decimal and another is the type not castable (e.g., string) to decimal, an assertion fires. On the other hand, we have a graceful way to error on dispatch failure in the general kernel dispatching path after this special casting:

Function 'greater' has no kernel matching input types (string, double)

We want to unify the error path for decimal.

What changes are included in this PR?

Bypass the decimal casting early and not error out if we see the other argument is not castable to decimal, and let the subsequent general kernel dispatching path to handle the error gracefully.

Are these changes tested?

Test included.

Are there any user-facing changes?

None.

@zanmato1984
Copy link
Contributor Author

cc @pitrou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant