Skip to content

Remove unused code from ByteBufVisitor #4383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hezhangjian merged 1 commit into from
May 24, 2024
Merged

Remove unused code from ByteBufVisitor #4383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ByteBufVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,12 +162,6 @@ private void passBufferToCallback(ByteBuf visitBuffer, int visitIndex, int visit
handleArray(visitBuffer.array(), visitBuffer.arrayOffset() + visitIndex, visitLength);
} else if (visitBuffer.hasMemoryAddress() && callback.acceptsMemoryAddress(callbackContext)) {
callback.visitBuffer(callbackContext, visitBuffer, visitIndex, visitLength);
} else if (callback.acceptsMemoryAddress(callbackContext) && visitBuffer.isDirect()
&& visitBuffer.alloc().isDirectBufferPooled()) {
// read-only buffers need to be copied before they can be directly accessed
ByteBuf copyBuffer = visitBuffer.copy(visitIndex, visitLength);
callback.visitBuffer(callbackContext, copyBuffer, 0, visitLength);
copyBuffer.release();
} else {
// fallback to reading the visited buffer into the copy buffer in a loop
byte[] copyBuffer = TL_COPY_BUFFER.get();
Expand Down