Skip to content

Conversation

@smiklosovic
Copy link
Contributor

No description provided.

Copy link
Contributor

@frankgh frankgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left a couple of comments. I was going to suggest adding an integration test, but Analytics currently only supports 4.0, so we won't be able to test it yet

COMMIT_THREADS_PER_INSTANCE,
COMMIT_BATCH_SIZE,
SKIP_EXTENDED_VERIFY,
SKIP_ROWS_VIOLATING_CONSTRAINTS,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you maybe add a comment here that this feature is only available in Cassandra 5.0 version? Or is it 6?

Copy link
Contributor Author

@smiklosovic smiklosovic Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankgh thank you for the review but I am not sure this approach is still viable based on the discussion in the related ticket. Did I interpret that comment correctly when I think that what I did here is itself not enough to consider CASSANALYTICS-32 to be resolved as we need to expose failed rows somehow, but this I am trying to do here is nice to have / the first step towards that direction which is valuable already to have as such?

https://issues.apache.org/jira/browse/CASSANALYTICS-32?focusedCommentId=17980384&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17980384

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I saw the comment from Yifan after I reviewed the PR. I think it's a good first approach, you need to explicitly enable this feature in order to write data that does not violate the constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants