CASSANALYTICS-90: Add table property to CqlTable #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankgh
reviewed
Sep 17, 2025
|
|
||
| public enum TableProperty | ||
| { | ||
| CDC("cdc"), |
Contributor
There was a problem hiding this comment.
I think we should match this to org.apache.cassandra.spark.utils.CqlUtils#TABLE_PROPERTY_OVERRIDE_ALLOWLIST because we are bounded to the table property override list. Also, we should really test this to make sure this works when we are parsing the CQL statement and converting that to a CqlTable, like we do in CassandraDataLayer
String createStmt = CqlUtils.extractTableSchema(fullSchema, keyspace, table);
....
cqlTable = bridge().buildSchema(createStmt, keyspace, replicationFactor, partitioner, udts, null, indexCount, false);
bbotella
force-pushed
the
CASSANALYTICS-90-support-table-options-on-cqltable
branch
from
70bef5d to
345da3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CASSANALYTICS-90