Pinterest open source: early shuffle deletion #3564
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
reviewed
Dec 12, 2025
|
|
||
| trait RunningStageManager { | ||
| def isRunningStage(stageId: Int): Boolean | ||
| } |
Member
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
this is a version based on the original implementation of that PR, I will clean it up to merge to master branch
Contributor
|
Is there any design doc for this feature? This feature is what I needed. |
Contributor
|
@FMX I will post the design description/doc while trying to merge this feature to master branch (as it was developed based on 0.4 internally)... on the other side, I am discussing with @YaoRazor , it seems we missed certain important pieces of code when upstreaming, so please do not bother look at the current implementation, it missed many things |
YaoRazor
force-pushed
the
pinterest/chopin
branch
from
73dc785 to
c0c4019
Compare
Contributor
|
I have started merging code to main branch at #3569, should be ready before the new year |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR represents Pinterest work to aggressively delete shuffle data
Ack
The main work is done by @CodingCat while he is working here, I am currently rolling out the feature and see good results
Why are the changes needed?
Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
How was this patch tested?