fix(test): Prevent panic in AfterSuite when BeforeSuite fails #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my-ship-it
approved these changes
Oct 17, 2025
If the BeforeSuite hook fails before the database connection is
initialized, the `connectionPool` variable remains nil. A common cause
is a misconfigured test environment, such as when `greenplum_path.sh`
is not sourced, leading to a "command not found" error for `createdb`.
The previous AfterSuite logic would then attempt to dereference this
nil pointer, causing a panic.
```
Running Suite: database query tests - /home/cbdb/Projects/gpbackup/integration
==============================================================================
Random Seed: 1760521199 - will randomize all specs
Will run 549 of 552 specs
------------------------------
[BeforeSuite] [FAILED] [0.003 seconds]
[BeforeSuite]
/home/cbdb/Projects/gpbackup/integration/integration_suite_test.go:54
[FAILED] Cannot create database testdb; is GPDB running?
In [BeforeSuite] at: /home/cbdb/Projects/gpbackup/integration/integration_suite_test.go:58 @ 10/15/25 17:40:06.839
------------------------------
[AfterSuite] [PANICKED] [0.000 seconds]
[AfterSuite]
/home/cbdb/Projects/gpbackup/integration/integration_suite_test.go:127
[PANICKED] Test Panicked
In [AfterSuite] at: /usr/lib/go-1.23/src/runtime/panic.go:262 @ 10/15/25 17:40:06.839
runtime error: invalid memory address or nil pointer dereference
Full Stack Trace
github.com/apache/cloudberry-backup/integration.init.func10()
/home/cbdb/Projects/gpbackup/integration/integration_suite_test.go:129 +0x26
------------------------------
Summarizing 2 Failures:
[FAIL] [BeforeSuite]
/home/cbdb/Projects/gpbackup/integration/integration_suite_test.go:58
[PANICKED!] [AfterSuite]
/usr/lib/go-1.23/src/runtime/panic.go:262
Ran 0 of 552 Specs in 0.023 seconds
FAIL! -- A BeforeSuite node failed so all tests were skipped.
--- FAIL: TestQueries (0.03s)
FAIL
Ginkgo ran 1 suite in 7.163251311s
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the BeforeSuite hook fails before the database connection is initialized, the
connectionPoolvariable remains nil. A common cause is a misconfigured test environment, such as whengreenplum_path.shis not sourced, leading to a "command not found" error forcreatedb.The previous AfterSuite logic would then attempt to dereference this nil pointer, causing a panic.