Autmation: update pipeline & fix hive file copy #20
Conversation
Tests may stuck for some reason and github will kill CI pipeline leaving us without any clue what happened. This change limits time for each step to run. When timeout raised - github will kill single step, and other steps will collect results and will provide test reports with logs.
|
@tuhaihe , should I sign CLA Agreement? Commit message template says that I should. However there is no description on how this process organized. |
.github/workflows/pxf-ci.yml
Outdated
| FAILED_COUNT="${{ steps.collect_artifacts.outputs.failed_count || 0 }}" | ||
| SKIPPED_COUNT="${{ steps.collect_artifacts.outputs.skipped_count || 0 }}" | ||
| if [ "${{ steps.run_test.outcome }}" == "failure" ] || [ "$FAILED_COUNT" -gt 0 ] || [ "$SKIPPED_COUNT" -gt 0 ]; then |
There was a problem hiding this comment.
SKIPPED_COUNT > 0 is failed?
There was a problem hiding this comment.
Sometimes it marks tests as skipped due to unavailability of some jsystem's resources.
Let me check it again.
There was a problem hiding this comment.
Ok... It in fact more complicated than I thought before.
Old TestNG versions has bug testng-team/testng#739 - when @BeforeClass(alwaysRun = true) fails - all tests are marked as SKIPPED despite of alwaysRun = true. Fixed in 6.9.5+.
Originally, almost all tests in open-gpdb/pxf failed somwhere inside doInit() methods - and all our tests were marked as SKIPPED. And then we decided to think about such tests as FAILED.
So, it seems we can just bump testng version. In this scenario I will expect that tests will be FAILED instead of SKIPPED. I will update this PR.
There was a problem hiding this comment.
It looks complicated. Please let me know when you're ready for the review. I will review the code.
Old TestNG versions has bug testng-team/testng#739 - when `@BeforeClass(alwaysRun = true)` fails - all tests are marked as SKIPPED despite of `alwaysRun = true`. Fixed in 6.9.5+.
3 participants
This PR consist of two changes:
@BeforeClassmethods raised an exception.