Fix: Add load/performance/extension test groups and align env/test ex… #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pectations - add bench_test and pxf_extension_test in run_tests.sh, plus matrix entries for bench and pxf_extension in CI - bump surefire heap to 4G to avoid OOM - update gpupgrade expected outputs to new PXF_HOME paths and JSON formatter error text - make ProtocolUtils/HiveBaseTest/JdbcHiveTest/OrcWriteTest/ParquetWriteTest more robust to env defaults (protocol, creds, hive JDBC URL) - keep MultiServerTest running under HDFS with a safe working directory fallback - set distribution key and INSERT pattern for performance test data load
| else | ||
| export JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::') | ||
| fi | ||
| export JAVA_HOME=/usr/lib/jvm/java-8-openjdk |
Collaborator
There was a problem hiding this comment.
delete Auto-detect Java 8 path for different architectures？
| return System.getProperty(AWS_ACCESS_KEY_ID); | ||
| String access = System.getProperty(AWS_ACCESS_KEY_ID); | ||
| String result = access != null ? access : System.getenv(AWS_ACCESS_KEY_ID); | ||
| System.out.println("DEBUG: doInit() method called getAccess " + result); |
Collaborator
There was a problem hiding this comment.
this is a debug print?
| hdfs.getWorkingDirectory() + "/" + fileName); | ||
| // load to hive table | ||
| hive.loadData(tableName, hdfsPath, false); | ||
| hive.loadData(tableName, hdfs.getWorkingDirectory() + "/" + fileName, false); |
Collaborator
There was a problem hiding this comment.
Sometimes HDFS metadata loading isn't that fast. Would it be better to add hdfs.waitForFile? ensure data load successfully?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pectations
fix #ISSUE_Number
Change logs
Contributor's checklist
Here are some reminders before you submit your pull request: