Fix pg_dump TAP tests. #1505
Open
Fix pg_dump TAP tests. #1505
+10
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currecntly TAP tests for pg_dump are red.
```
Test Summary Report
-------------------
t/002_pg_dump.pl (Wstat: 25088 (exited 98) Tests: 7138 Failed: 98)
Failed tests: 112, 327, 542, 972, 1402, 1618, 1834, 1976-1977
1979-1982, 1987-1988, 1993-1995, 2001-2002
2004, 2010, 2013, 2015, 2023, 2032-2033
2043, 2045-2050, 2054, 2063, 2073-2074
2086-2091, 2093-2094, 2101-2104, 2108, 2125
2135, 2155, 2158-2167, 2169-2171, 2180
2182, 2185-2189, 2270, 2915, 3345, 3560
3775, 3990, 4205, 4420, 4635, 4850, 5633-5634
5644-5645, 5680, 5730, 5812, 5819, 5824
5845-5846, 6141, 6786, 7001
Non-zero exit status: 98
t/004_pg_dump_parallel.pl (Wstat: 1024 (exited 4) Tests: 4 Failed: 4)
Failed tests: 1-4
Non-zero exit status: 4
t/010_dump_connstr.pl (Wstat: 768 (exited 3) Tests: 14 Failed: 3)
Failed tests: 7-9
Non-zero exit status: 3
```
Issues cause is appendonly-speicific test and parrallel dump. Fix first
by modifying TAP perl regex. Fix latter by fixing rebase issues with 56b46d3 with changes for pg_backup_archiver.c
Contributor
Author
|
I guess we need to run |
Contributor
Author
I made #1506 for this |
|
|
||
| /* re-establish fixed state */ | ||
| if (AH->mode == archModeRead) | ||
| { |
Contributor
There was a problem hiding this comment.
Why remove this judgement?
Contributor
Author
There was a problem hiding this comment.
Thats because of 56b46d3, basically. Changes of this commit are half-made in cloudberry. This code is creating connection both before and after if (AH->mode == archModeRead) statement (on line 4934 and if each of if-else branch). This causes an error of assertion failure in pg_dump parallel run (pg_dump -j$num, see examples in TAP test for exact command).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currecntly TAP tests for pg_dump are red.
Issues cause is append only - specific test and parallel dump. Fix first by modifying TAP perl regex. Fix latter by fixing rebase issues with 56b46d3 with changes for pg_backup_archiver.c
Found during PG16 rebase and cross-validation with main branch and PG upstream.