-
Notifications
You must be signed in to change notification settings - Fork 119
Update GPU related docs #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sureshanaparti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates GPU-related documentation to provide better clarity and technical guidance for GPU configuration in CloudStack. The changes enhance existing documentation with specific technical details and compatibility information.
- Added clarification about CPVM display requirements for GPU instances
- Enhanced GPU discovery script documentation with dependency requirements
- Added NVIDIA vGPU compatibility matrix for CloudStack support
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| source/adminguide/service_offerings.rst | Added technical note about video hardware settings for GPU display configuration |
| source/adminguide/hosts.rst | Enhanced GPU discovery documentation with dependencies and NVIDIA vGPU compatibility matrix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| This is applicable only for KVM hypervisor. | ||
| This is applicable only for KVM hypervisor. Depending on the OS and display configuration, | ||
| the user might need to set ``video.hardware`` to ``none`` in the instance's settings to | ||
| use CPVM for display. |
Copilot
AI
Aug 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation should clarify where exactly the instance settings are located and how to access them. Consider adding the specific path or UI location where users can modify the video.hardware setting.
| use CPVM for display. | |
| use CPVM for display. To modify the ``video.hardware`` setting, navigate to the instance's details page in the CloudStack UI, click on the "Settings" tab, and locate the ``video.hardware`` option to change its value. |
| ``/usr/share/cloudstack-common/scripts/vm/`` directory on the host. The script | ||
| relies on the ``lspci`` & ``xmlstarlet`` command to discover the GPU devices | ||
| and their status on the host. So, for the discovery to be successful, the | ||
| ``lspci`` & ``xmlstarlet`` commands needs to be installed on the host. |
Copilot
AI
Aug 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subject-verb disagreement: 'commands needs' should be 'commands need' (plural subject requires plural verb).
| ``lspci`` & ``xmlstarlet`` commands needs to be installed on the host. | |
| ``lspci`` & ``xmlstarlet`` commands need to be installed on the host. |
📚 Documentation preview 📚: https://cloudstack-documentation--538.org.readthedocs.build/en/538/