UI: Fix for cluster addition in VMware #11812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sureshanaparti
requested review from
DaanHoogland,
harikrishna-patnala and
shwstppr
Contributor
Author
|
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11812 +/- ##
============================================
- Coverage 17.54% 17.53% -0.02%
- Complexity 15470 15556 +86
============================================
Files 5897 5897
Lines 527349 531662 +4313
Branches 64403 66159 +1756
============================================
+ Hits 92514 93211 +697
- Misses 424437 427992 +3555
- Partials 10398 10459 +61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
github-project-automation
bot
moved this from In Progress
to Done
in Apache CloudStack 4.22.0
Contributor
|
tested the changes on my env and I could a cluster and host in it got discovered. |
harikrishna-patnala
added
status:ready-for-merge
and removed
status:needs-testing
labels
github-project-automation
bot
moved this from In Progress
to Done
in Apache CloudStack 4.22.0
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes cluster addition in VMware. It's a regression issue due to #9752.
Fixes #11774
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Added new VMware cluster from UI.
How did you try to break this feature and the system with this change?