-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Clarify truncate method Javadoc #1536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Improves the truncate method documentation to better describe substring behavior.
garydgregory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Akshat19Upadhyay
Thank you for the PR.
Please rebase on git master and see my comment.
Clarifies return value description and removes extra line break.
garydgregory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new text is wrong.
Updates the truncate Javadoc to clarify behavior when the String is shorter than maxWidth and that zero is a valid non-negative value.
|
Thanks for the review. |
garydgregory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new text is still wrong.
|
Hi @garydgregory, thanks for the review. |
Improves the truncate method documentation to better describe substring behavior.
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.