Skip to content

Conversation

@rajucomp
Copy link

@rajucomp rajucomp commented Dec 14, 2025

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

See https://issues.apache.org/jira/browse/POOL-426 for more details.

@rajucomp
Copy link
Author

@garydgregory @psteitz Requesting critical review for the fix for POOL-426. Thanks!

@garydgregory
Copy link
Member

Hi @psteitz Any thoughts on this one?

@psteitz
Copy link
Contributor

psteitz commented Dec 24, 2025

Analysis looks correct to me. This plus revert of bugged fix for POOL-425 should work. I am having trouble getting the patch applied to the right branch. Will review and merge once fully tested. Thanks for the patch.

@garydgregory
Copy link
Member

I can cut a release candidate when we have a fix validated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants