RAT-475: Removed unused packages from modules

[Claudenw]

• Remove unused packages
• replace OptionTest interface with Junit5 Executable.

[ottlinger]

@Claudenw kudos for taking a closer look into the failing tests on GHA .... cool!

Can you run the tests from within the IDE? I get test failures, while everything works fine if run via .mvnw/console.

[ottlinger]

Should we add a test configuration of slf4j?
Running a single test in IntelliJ produces a warning.

[ottlinger]

Where is this library used? Do we really use it?

[ottlinger]

@Claudenw I hope that this PR fixes the latest windows test failures as well:
https://github.com/apache/creadur-rat/actions/runs/15487411180/job/43605115280#step:5:5280

[Claudenw]

I used the dependwncy plugin to list the dependency tree and it was listed there. It probably does not need to be included. LinkedIn: http://www.linkedin.com/in/claudewarren

…

On Tue 3 Jun 2025, 14:00 P. Ottlinger, ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In pom.xml <#471 (comment)>: > @@ -230,6 +235,16 @@ agnostic home for software distribution comprehension and audit tools. <version>1.3.0</version> <scope>test</scope> </dependency> + <dependency> + <groupId>org.slf4j</groupId> Should we add a test configuration of slf4j? Running a single test in IntelliJ produces a warning. ------------------------------ In pom.xml <#471 (comment)>: > @@ -230,6 +235,16 @@ agnostic home for software distribution comprehension and audit tools. <version>1.3.0</version> <scope>test</scope> </dependency> + <dependency> + <groupId>org.slf4j</groupId> + <artifactId>slf4j-api</artifactId> + <version>2.0.17</version> + </dependency> + <dependency> + <groupId>com.github.albfernandez</groupId> Where is this library used? Do we really use it? — Reply to this email directly, view it on GitHub <#471 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASTVHSHI2PE6VLXF64XVC33BWL5HAVCNFSM6AAAAAB6J2FIFWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQOBWGEZDSMBYGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ottlinger]

@Claudenw removing both of the dependencies yields a failure of the site build in Rat::Core
"Artifact has not been packaged yet. When used on reactor artifact, unpack should be executed after packaging".
The regular build (./mvnw running the default goal) goes through successfully.

The build fails right after trying to unpack apache-rat-testdata:0.17-SNAPSHOT:jar.

My local diff was just removing both of the dependencies in the main pom.xml:

• slf4j-api
• juniversalchardet

Can you verify locally?

[ottlinger]

@Claudenw I just rechecked locally - the site build fails on that branch .... with the packaging error. Do you experience the same issue?

./mvnw clean package site site:stage

Not sure if we are running a wrong target but if I remember correctly we introduced this package when the new generators were put into place. Replacing package with install does not solve the issue.

I assume there's still something wrong within the tree of dependencies.

[Claudenw]

closing will not merge