Skip to content

Disabling the LCS caching as it provides inconsistent results #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlpainter wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Disabling the LCS caching as it provides inconsistent results #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...ytex/src/main/java/org/apache/ctakes/ytex/kernel/metric/ConceptSimilarityServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,14 @@
*
*/
public class ConceptSimilarityServiceImpl implements ConceptSimilarityService {

// The original implementation included code to cache LCS's to save
// computation time. However, this resulted in distance metrics that
// were inconsistent when calling subsequent CUI pairs. To ensure
// replicable results across calls to the similarity service, the
// caching mechanism should be disabled for now.
private static boolean ENABLE_LCS_CACHING = false;

private static final Log log = LogFactory
.getLog(ConceptSimilarityServiceImpl.class);

Expand Down Expand Up @@ -630,7 +638,9 @@ private int getLCSFromCache(ConcRel cr1, ConcRel cr2, Set<String> lcses) {
.getConceptID() : cr1.getConceptID());
String cacheKey = cacheKeyBuilder.toString();
Element e = this.lcsCache != null ? this.lcsCache.get(cacheKey) : null;
if (e != null) {

// If the LCS cache is disabled, we will fall through
if (e != null && ENABLE_LCS_CACHING == true) {
// hit the cache - unpack the lcs
if (e.getObjectValue() != null) {
Object[] val = (Object[]) e.getObjectValue();
Expand Down