Skip to content

Conversation

@manuzhang
Copy link
Member

@manuzhang manuzhang commented Nov 27, 2025

Which issue does this PR close?

First step of #2792.

Rationale for this change

What changes are included in this PR?

  1. Add spark-4.1 profile with minor shim version spark-4.1
  2. Move src/main/spark-4.0 to src/main/spark-4.x for common shim classes in spark-4.0 and spark-4.1.
  3. Add CometSumShim and ShimSQLConf for spark-4.0 and spark-4.1 specific shims respectively
  4. Add MapStatusBuilder.scala to access org.apache.spark.scheduler.MapStatus in java. MapStatus has added a constructor argument in Spark 4.1, and only kept compatibility for scala codes.

How are these changes tested?

Added UTs.

@manuzhang manuzhang marked this pull request as draft November 27, 2025 08:28
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.61%. Comparing base (f09f8af) to head (4207552).
⚠️ Report is 793 commits behind head on main.

Files with missing lines Patch % Lines
.../comet/execution/shuffle/CometShuffleManager.scala 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2829      +/-   ##
============================================
+ Coverage     56.12%   59.61%   +3.48%     
- Complexity      976     1384     +408     
============================================
  Files           119      168      +49     
  Lines         11743    15501    +3758     
  Branches       2251     2569     +318     
============================================
+ Hits           6591     9241    +2650     
- Misses         4012     4959     +947     
- Partials       1140     1301     +161     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@manuzhang manuzhang force-pushed the spark-4.1 branch 4 times, most recently from 31cf1ca to 88f8b68 Compare November 28, 2025 04:33
@manuzhang manuzhang marked this pull request as ready for review December 22, 2025 02:43
@manuzhang manuzhang force-pushed the spark-4.1 branch 4 times, most recently from 6d6dfb4 to 2956aac Compare December 22, 2025 10:50
@manuzhang
Copy link
Member Author

@andygrove @coderfender Please help review. Do we need to pass all tests now?

Co-authored-by: Andy Grove <agrove@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants