Skip to content

Conversation

@kazantsev-maksim
Copy link
Contributor

@kazantsev-maksim kazantsev-maksim commented Dec 14, 2025

Which issue does this PR close?

Part of #2084

Rationale for this change

It was recently added to DF: apache/datafusion#17779

What changes are included in this PR?

How are these changes tested?

A new UT has been added.

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kazantsev-maksim for the PR, triggering the CI

Appreciate if you can also add the function to the FuzzTestingSuite similar to Meta.scala

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.61%. Comparing base (f09f8af) to head (70599d5).
⚠️ Report is 801 commits behind head on main.

Files with missing lines Patch % Lines
...k/src/main/scala/org/apache/comet/serde/maps.scala 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2905      +/-   ##
============================================
+ Coverage     56.12%   59.61%   +3.49%     
- Complexity      976     1377     +401     
============================================
  Files           119      167      +48     
  Lines         11743    15507    +3764     
  Branches       2251     2574     +323     
============================================
+ Hits           6591     9245    +2654     
- Misses         4012     4962     +950     
- Partials       1140     1300     +160     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Kazantsev Maksim and others added 10 commits December 16, 2025 09:06
# Conflicts:
#	spark/src/main/scala/org/apache/comet/serde/maps.scala
#	spark/src/test/scala/org/apache/comet/CometMapExpressionSuite.scala
# Conflicts:
#	spark/src/test/scala/org/apache/comet/CometMapExpressionSuite.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants