-
Notifications
You must be signed in to change notification settings - Fork 260
Feat: map_from_entries #2905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat: map_from_entries #2905
Conversation
comphead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kazantsev-maksim for the PR, triggering the CI
Appreciate if you can also add the function to the FuzzTestingSuite similar to Meta.scala
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2905 +/- ##
============================================
+ Coverage 56.12% 59.61% +3.49%
- Complexity 976 1377 +401
============================================
Files 119 167 +48
Lines 11743 15507 +3764
Branches 2251 2574 +323
============================================
+ Hits 6591 9245 +2654
- Misses 4012 4962 +950
- Partials 1140 1300 +160 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 768b3e9.
# Conflicts: # spark/src/main/scala/org/apache/comet/serde/maps.scala # spark/src/test/scala/org/apache/comet/CometMapExpressionSuite.scala
# Conflicts: # spark/src/test/scala/org/apache/comet/CometMapExpressionSuite.scala
Which issue does this PR close?
Part of #2084
Rationale for this change
It was recently added to DF: apache/datafusion#17779
What changes are included in this PR?
How are these changes tested?
A new UT has been added.