Skip to content

Conversation

@manuzhang
Copy link
Member

Which issue does this PR close?

Closes #2927.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.60%. Comparing base (f09f8af) to head (025d2fc).
⚠️ Report is 784 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2951      +/-   ##
============================================
+ Coverage     56.12%   59.60%   +3.47%     
- Complexity      976     1381     +405     
============================================
  Files           119      167      +48     
  Lines         11743    15493    +3750     
  Branches       2251     2568     +317     
============================================
+ Hits           6591     9234    +2643     
- Misses         4012     4959     +947     
- Partials       1140     1300     +160     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@manuzhang manuzhang force-pushed the prek branch 14 times, most recently from 7a6f8a1 to 33b55fa Compare December 21, 2025 15:44
@manuzhang manuzhang marked this pull request as ready for review December 21, 2025 15:47
@coderfender
Copy link
Contributor

I personally setup a pre commit hook but with specific shell commands to make sure that compilation , run spotless and prettier commands. That said, I don't think adding a pre commit hook at a project level might be the bestest idea :)

@manuzhang
Copy link
Member Author

The gap is while checking code style is part of maven build, it is not for cargo build. Meanwhile, whether to run precommit hook locally is optional to developers with prek install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add precommit hook with prek

3 participants