Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Dec 23, 2025

Which issue does this PR close?

N/A

Rationale for this change

Refactoring to simplify scan selection and fallback logic

What changes are included in this PR?

No functional changes. Just refactoring.

How are these changes tested?

Existing tests.

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2025

Codecov Report

❌ Patch coverage is 69.04762% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.54%. Comparing base (f09f8af) to head (bce716a).
⚠️ Report is 799 commits behind head on main.

Files with missing lines Patch % Lines
...n/scala/org/apache/comet/rules/CometScanRule.scala 69.04% 6 Missing and 7 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2978      +/-   ##
============================================
+ Coverage     56.12%   59.54%   +3.42%     
- Complexity      976     1377     +401     
============================================
  Files           119      167      +48     
  Lines         11743    15522    +3779     
  Branches       2251     2571     +320     
============================================
+ Hits           6591     9243    +2652     
- Misses         4012     4980     +968     
- Partials       1140     1299     +159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove marked this pull request as draft December 23, 2025 17:43
@andygrove andygrove changed the title chore: Refactor CometScanRule to improve scan selection and fallback logic chore: Refactor CometScanRule to improve scan selection and fallback logic [WIP] Dec 23, 2025
@andygrove andygrove marked this pull request as ready for review December 23, 2025 18:50
@andygrove andygrove changed the title chore: Refactor CometScanRule to improve scan selection and fallback logic [WIP] chore: Refactor CometScanRule to improve scan selection and fallback logic Dec 23, 2025
@andygrove andygrove marked this pull request as draft December 23, 2025 21:22
@andygrove andygrove changed the title chore: Refactor CometScanRule to improve scan selection and fallback logic chore: Refactor CometScanRule to improve scan selection and fallback logic [WIP] Dec 23, 2025
@andygrove andygrove changed the title chore: Refactor CometScanRule to improve scan selection and fallback logic [WIP] chore: Refactor CometScanRule to improve scan selection and fallback logic Dec 24, 2025
@andygrove andygrove marked this pull request as ready for review December 24, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants