Skip to content

Conversation

@r-sidd
Copy link
Contributor

@r-sidd r-sidd commented Oct 28, 2024

What is the purpose of the change

Migrate kryo package

Brief change log

Kryo has been moved to the com.esotericsoftware package. Updating to this version will enhance capabilities, ensure the dependency is up to date, and address vulnerabilities in the current dependencies, specifically CVE-2020-15250

Package details: https://mvnrepository.com/artifact/com.esotericsoftware/kryo/4.0.3

Updating to version 4.0.3, as higher versions are causing local build failures.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: don't know
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 28, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@tomncooper
Copy link
Contributor

Looks like you have conflicting versions of org.ow2.asm:asm. You may need to override the transitive versions of kryo from other packages (in this case the one coming from com.twitter:chill-java in flink-streaming-java) in order to get the build to work.

@r-sidd
Copy link
Contributor Author

r-sidd commented Dec 18, 2024

Looks like you have conflicting versions of org.ow2.asm:asm. You may need to override the transitive versions of kryo from other packages (in this case the one coming from com.twitter:chill-java in flink-streaming-java) in order to get the build to work.

Hey thanks for the guidance, I'll try to make the necessary adjustments to get the build working.

@snuyanzin
Copy link
Contributor

isn't it a duplicate of
#22660
?

@nicknezis
Copy link

Yes. this seems to be a duplicate. I would propose closing it and deferring to the existing FLIP-317 and #22660 PR.

@davidradl
Copy link
Contributor

@r-sidd are you ok to close and pursue resolution via the Flip?

@github-actions
Copy link

This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale label Apr 17, 2025
@github-actions
Copy link

This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants