-
Notifications
You must be signed in to change notification settings - Fork 11
Deprecate archived projects #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The plugins have been marked as archived on Github.
Added the deprecated attribute to the plugins metadata with the message:
"This repository was archived by the owner..."
…c, segment The metadata has been updated with a "deprecated" message
The two projects have been merged into one project and "adopted" by Apache Grails
The plugins have been moved to Apache and the grails-data-mapping project
Theu have all been integrated into the grails-spring-security-core project
Moved to a new project from owner 'grails' to 'grails-plugins'
|
Several of these projects weren't archived directly - they were just moved and the original repo is archived. @jamesfredley did we intend to add the other ones somewhere else? for example, spring-security-rest is still very active, but it's under https://github.com/apache/grails-spring-security |
|
I am not familiar enough with how this file is used, but we do need to handle the plugins which were consolidated to a new location and also address the ones with new apache maven groupids. asset-pipeline falls into the same boat with the new groupid. Does the existing entry get updated or do we create a new one for the new coordinates? |
|
I just checked the entries in the grails-plugins.json file against the GitHub API, fx.: And if "isArchived" was true I added a "deprecated" field with the message "This repository was archived by the owner on THE_DATE", The JSON file is fetched from the Grails Static Website https://github.com/apache/grails-static-website/blob/master/buildSrc/src/main/groovy/org/grails/gradle/PluginsTask.groovy#L28 when generating the plugin.html page. We could discuss it at the next "Apache Grails Weekly Planning Meeting" on the 13. of august? |
|
@dauer Yes, I added the deprecated property when going over the plugin list to get some sanity. |
Updated metadata: Some of the projects have been moved into the Apache Grails Core repo - grails-converters - grails-data-hibernate5-dbmigration - grails-fields - grails-geb - grails-gsp - grails-data-mongodb - grails-scaffolding - grails-spring-security-acl - grails-spring-security-cas - grails-spring-security-ldap - grails-spring-security-oauth2 - grails-spring-security-rest - grails-spring-security-rest-datamapping - grails-spring-security-rest-redis - grails-spring-security-ui
I have updated the metadata for the plugins that have been moved to the Apache Grails Core project |
| @@ -221,6 +223,7 @@ | |||
| "readme": "<h1>Grails 3 Angular Scaffolding Plugin</h1>\n<p><a href=\"https://travis-ci.org/grails-plugins/grails-angular-scaffolding\"><img src=\"https://travis-ci.org/grails-plugins/grails-angular-scaffolding.svg?branch=master\" alt=\"Build Status\" /></a></p>\n<p>A plugin for generating client side assets based on domain classes</p>\n<h2>Documentation</h2>\n<p>Latest: https://grails-plugins.github.io/grails-angular-scaffolding/latest\nSnapshot: https://grails-plugins.github.io/grails-angular-scaffolding/snapshot</p>\n" | |||
| }, | |||
| { | |||
| "deprecated": "This repository was archived by the owner on Feb 28, 2025. It is now read-only.", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to https://github.com/apache/grails-core does not make it deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We removed the angular profile and suggest end users use the rest api, so this is correct
grails-plugins.json
Outdated
| @@ -1122,6 +1136,7 @@ | |||
| "readme": null | |||
| }, | |||
| { | |||
| "deprecated": "This repository was archived by the owner on Sep 10, 2024. It is now read-only.", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to https://github.com/apache/grails-core does not make it deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugin should be deprecated because it was combined into grails-core?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated to point to grails-core since it has its own released artifact https://repo1.maven.org/maven2/org/grails/grails-console/maven-metadata.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, i viewed the wrong package, this is grails-web-console not grails-console
| @@ -1930,6 +1947,7 @@ | |||
| "readme": "<p><a href=\"https://github.com/sbglasius/external-config\">See the README</a> on GitHub</p>" | |||
| }, | |||
| { | |||
| "deprecated": "This repository was archived by the owner on Jan 18, 2023. It is now read-only.", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to https://github.com/apache/grails-core does not make it deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find where it has been moved to?
grails-plugins.json
Outdated
| @@ -2859,6 +2879,7 @@ | |||
| "readme": "<h1>Grails Views</h1>\n<p>Additional View Technologies for Grails 3.0 and above.</p>\n<p>Initial implementation includes JSON views powered by Groovy's JsonBuilder, however this project provides the basis for implementation other view types.</p>\n<p>View <a href=\"https://grails.github.io/grails-views/latest/\">the latest documentation</a> for details.</p>\n<p><a href=\"https://github.com/grails/grails-views/actions/workflows/gradle.yml\"><img src=\"https://github.com/grails/grails-views/actions/workflows/gradle.yml/badge.svg?branch=master\" alt=\"Java CI\" /></a></p>\n" | |||
| }, | |||
| { | |||
| "deprecated": "This repository was archived by the owner on Apr 14, 2025. It is now read-only.", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to https://github.com/apache/grails-core does not make it deprecated?
| "documentationUrl": "https://grails.github.io/grails-data-mapping/", | ||
| "mavenMetadataUrl": "https://repo1.maven.org/maven2/org/grails/plugins/hibernate5/maven-metadata.xml", | ||
| "documentationUrl": null, | ||
| "mavenMetadataUrl": "https://repo1.maven.org/maven2/org/apache/grails/grails-data-hibernate5/maven-metadata.xml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hibernate4 vs hibernate5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old and the new url both contains hibernate5 ?
grails-plugins.json
Outdated
| ], | ||
| "vcsUrl": "https://github.com/grails/grails-spring-security-oauth2" | ||
| "vcsUrl": "https://github.com/apache/grails-core" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grails-plugins.json
Outdated
| ], | ||
| "vcsUrl": "https://github.com/alvarosanchez/grails-spring-security-rest" | ||
| "vcsUrl": "https://github.com/apache/grails-core" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grails-plugins.json
Outdated
| ], | ||
| "vcsUrl": "https://github.com/grails-plugins/grails-spring-security-rest" | ||
| "vcsUrl": "https://github.com/apache/grails-core" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grails-plugins.json
Outdated
| ], | ||
| "vcsUrl": "https://github.com/alvarosanchez/grails-spring-security-rest" | ||
| "vcsUrl": "https://github.com/apache/grails-core" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grails-plugins.json
Outdated
| ], | ||
| "vcsUrl": "https://github.com/grails-plugins/grails-spring-security-ui" | ||
| "vcsUrl": "https://github.com/apache/grails-core" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the
deprecatedattribute with a short description to plugins where the GitHub repository had been archived or in some cases removed