Add the rest of the _convert_schema_if_needed calls

[rambleraptor]

Closes #2270

This adds the rest of the _convert_schema_if_needed calls.

Rationale for this change

Are these changes tested?

Are there any user-facing changes?

[kevinjqliu]

Thanks for the PR!

Looks like theres one more usage of _convert_schema_if_needed here
And another usage of pyarrow_to_schema here

I think we should pass format_version down in both.

I found these by checking the signature changes in #2294
These 3 functions were changed as well, but i double checked them and they are all good.

_pyarrow_to_schema_without_ids
_ConvertToIceberg
_check_pyarrow_schema_compatible

[rambleraptor]

good call. both instances fixed

[rambleraptor]

Hey @kevinjqliu, sorry this took so long! I was OOO (literally on a boat with poor WiFi...), so I'm just getting to this now. Let me know if there's anything else you need!

[kevinjqliu]

looks like the linter errored

pyiceberg/table/update/schema.py:146: error: Incompatible default for argument "format_version" (default has type "Literal['TableProperties.DEFAULT_FORMAT_VERSION']", argument has type "Literal[1, 2, 3]")  [assignment]

[rambleraptor]

Ugh, circular imports! I made a fix with a TODO. The proper solution is to move TableProperties to a separate module. Happy to do that, but that feels bigger than this PR.

[kevinjqliu]

The proper solution is to move TableProperties to a separate module

yea makes sense we can follow up and fix the TODO

[kevinjqliu]

LGTM

[kevinjqliu]

Thanks for the PR @rambleraptor