feat: Allow servers to express supported endpoints with ConfigResponse#2848
Merged
kevinjqliu merged 3 commits intoapache:mainfrom Dec 29, 2025
Merged
feat: Allow servers to express supported endpoints with ConfigResponse#2848kevinjqliu merged 3 commits intoapache:mainfrom
kevinjqliu merged 3 commits intoapache:mainfrom
Conversation
Contributor
|
wdyt about adding integration tests against the Running the integration test infra gives me this response on |
kevinjqliu
approved these changes
Dec 24, 2025
Contributor
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding this feature.
The PR looks good and is throughly tested. I just have a few nit comments.
Feel free to address here or as a follow up PR
kevinjqliu
approved these changes
Dec 29, 2025
Contributor
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM! One more comment about tests
We should probably test against the IRC server for integration test, maybe in tests/integration/test_rest_catalog.py. Can add to this PR or as a follow up
Contributor
|
Thanks! |
Fokko
pushed a commit
that referenced
this pull request
Jan 16, 2026
related to #2775 # Rationale for this change Adds **synchornous** client-side support for REST server side scan planning, allowing for scanning if the rest catalog supports it. This PR cherry-picks and builds on two WIP PRs: - Rest Models #2861 - Endpoints PR #2848 Currently scanning is enable with rest-scan-planning-enabled=true in catalog properties. TODO: spec handling ## Are these changes tested? Integration tests added with manual testing ## Are there any user-facing changes? yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes to #2847
Rationale for this change
This PR adds the server endpoint capabilities support, aligning with the Java implementation. While working on the REST scanning support, we need to know if a server supports specific capabilities before making any calls. So this PR also adds some extra support for the current implementation of PI iceberg REST catalog.
The REST catalog will now parse the endpoints field from the config call to determine server capabilities. When a server doesn't respond, we have fallback logic that matches the behavior of Java's rest catalog. The View endpoints are conditionally added to the default with the config property as well.
Are these changes tested?
Added unit tests and tested with the iceberg rest fixture.
Are there any user-facing changes?
Yes added config and alignment with java impl.
cc: @kevinjqliu @Fokko