chore: Use SnapshotRefType Enum instead of hard-coded strings#2880
Merged
kevinjqliu merged 1 commit intoapache:mainfrom Jan 4, 2026
Merged
chore: Use SnapshotRefType Enum instead of hard-coded strings#2880kevinjqliu merged 1 commit intoapache:mainfrom
SnapshotRefType Enum instead of hard-coded strings#2880kevinjqliu merged 1 commit intoapache:mainfrom
Conversation
ebyhr
approved these changes
Jan 4, 2026
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Looks good to me. I confirmed there is no other hard-coded tag and branch.
geruh
approved these changes
Jan 4, 2026
Contributor
geruh
left a comment
geruh
left a comment
There was a problem hiding this comment.
Yeah this makes sense, thanks @jayceslesar!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Use the enum instead of hard-coded strings!
Everywhere else that
"branch"and"tag"are used seems to be in tests so I think fine to leave those aloneAre these changes tested?
No functional changes
Are there any user-facing changes?
No