Skip to content

Conversation

@kevinjqliu
Copy link
Contributor

Rationale for this change

(Copy over RAT upgrade changes from java, #15145, #15174, #15194)
Upgrades RAT to version 0.17, which has new regex for exclusion expression

  • Using --input-exclude-file because -E,--exclude-file is deprecated
  • Using --input-include-std HIDDEN_DIR because --scan-hidden-directories is deprecated
  • Using the new --output-style missing-headers option for output styling

Add usage of the new collections for ignore file patterns https://creadur.apache.org/rat/apache-rat/standard_collections.html

  • GIT matches **/.git/**, **/.gitignore
  • IDEA matches **/*.iws, **/*.iml, **/*.ipr, **/.idea/**
  • MAC matches **/.DS_Store

Are these changes tested?

yes locally and ci

Are there any user-facing changes?

Comment on lines +1 to +8
.github/**
dev/.rat-excludes
uv.lock
mkdocs/*
notebooks/*
.ruff_cache/**
.pytest_cache/**
.mypy_cache/**
mkdocs/**
notebooks/**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/* -> .github/**, new syntax to ignore all files in this folder
.rat-excludes -> dev/.rat-excludes, most specifically exclude this file
build folder is not longer produced
.git & .gitignore are covered by the GIT standard collection
adding some cache in python env .ruff_cache, .pytest_cache, .mypy_cache
mkdocs/* & notebooks/* using the new syntax to exclude this folder mkdocs/** & notebooks/**

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Fokko Fokko merged commit 985674e into apache:main Jan 31, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants