Fix "AlreadyExistsException: Location already exists" at rewrite_table_path #14859
+99
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/TestRewriteTablePathsAction.java
nastra
reviewed
Dec 17, 2025
...k/v4.0/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@nastra can you please review the changes |
dramaticlly
reviewed
Dec 23, 2025
...k/v4.0/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java
Show resolved
Hide resolved
Contributor
Author
|
@dramaticlly fixed the review comments, can you review it now. |
Contributor
|
@Bhargavkonidena it would be nice to have a test for #14814 if possible |
Bhargavkonidena
force-pushed
the
issue_14815
branch
from
4dfda1b to
c86dc63
Compare
Bhargavkonidena
force-pushed
the
issue_14815
branch
from
c86dc63 to
5ff0f4a
Compare
Bhargavkonidena
force-pushed
the
issue_14815
branch
from
5ff0f4a to
053c664
Compare
Contributor
Author
Done |
Contributor
Author
|
@nastra can you please review it now? |
nastra
reviewed
Jan 30, 2026
| // rebuild position delete files | ||
| // Use DeleteFileSet to ensure proper equality comparison based on file location, content | ||
| // offset, | ||
| // and content size. This is particularly important for deletion vectors (DV files) where |
Contributor
There was a problem hiding this comment.
nit: this line can go with the previous one
nastra
reviewed
Jan 30, 2026
| * based on file location, content offset, and content size. | ||
| */ | ||
| @TestTemplate | ||
| public void testPositionDeletesWithMultipleTagsOnSameSnapshot() throws Exception { |
Contributor
There was a problem hiding this comment.
I don't think this test actually reproduces the issue because the test passes for me even without the fix
Contributor
Author
There was a problem hiding this comment.
@nastra Updated the test case, can you validate it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14814