Core: Fix compute_table_stats failures with concurrent writes #15148
+90
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dramaticlly
reviewed
Jan 26, 2026
Contributor
dramaticlly
left a comment
dramaticlly
left a comment
There was a problem hiding this comment.
I think we shall add commit retry like other PendingUpdate implementation class, RemoveSnapshots is a good example. But we can probably simplify the unit test a bit
Contributor
|
@huaxingao @nastra I think this one is close, can you take a look as well? |
huaxingao
reviewed
Jan 30, 2026
| 2.0 /* exponential */) | ||
| .onlyRetryOn(CommitFailedException.class) | ||
| .run( | ||
| item -> { |
| TableMetadata newMetadata = internalApply(base); | ||
| ops.commit(base, newMetadata); | ||
| Tasks.foreach(ops) | ||
| .retry(base.propertyAsInt(COMMIT_NUM_RETRIES, COMMIT_NUM_RETRIES_DEFAULT)) |
Contributor
There was a problem hiding this comment.
retry config is pulled from base initialized at construction time. If table properties change between construction and commit(), retries won’t pick that up.
Contributor
There was a problem hiding this comment.
instead of adding a member variable base, could we simplify by using local base/updated variables per retry attempt (base = taskOps.refresh(); updated = internalApply(base); taskOps.commit(base, updated))?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compute_table_stats fails with CommitFailedException when concurrent writes modify table metadata during statistics computation.