Core: Fix rewriting delete manifests in RewriteTablePathUtil #15155
+38
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wobu
force-pushed
the
rewrite_table_path_fix_missing_delete_files
branch
from
888389d to
31a6f7e
Compare
dramaticlly
approved these changes
Jan 28, 2026
Contributor
dramaticlly
left a comment
dramaticlly
left a comment
There was a problem hiding this comment.
Thanks for the fix, I think it's reasonable to copy when we read manifest entries with reuseContainers. FYI @szehon-ho if you want to review as well
core/src/test/java/org/apache/iceberg/TestRewriteTablePathUtil.java
Outdated
Show resolved
Hide resolved
Contributor
|
LGTM except the nit comment. |
huaxingao
approved these changes
Jan 28, 2026
wobu
force-pushed
the
rewrite_table_path_fix_missing_delete_files
branch
from
31a6f7e to
80ec8b8
Compare
nastra
reviewed
Jan 28, 2026
nastra
reviewed
Jan 28, 2026
core/src/test/java/org/apache/iceberg/TestRewriteTablePathUtil.java
Outdated
Show resolved
Hide resolved
wobu
force-pushed
the
rewrite_table_path_fix_missing_delete_files
branch
from
80ec8b8 to
a3e9a5d
Compare
wobu
force-pushed
the
rewrite_table_path_fix_missing_delete_files
branch
from
a3e9a5d to
0efaa12
Compare
singhpk234
approved these changes
Jan 28, 2026
| RewriteTablePathUtil.rewriteDeleteManifest( | ||
| manifest, | ||
| Set.of(1000L), | ||
| org.apache.iceberg.Files.localOutput( |
Contributor
There was a problem hiding this comment.
[minor] can you import this rather than inlining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12772