Skip to content

Conversation

@adutra
Copy link
Contributor

@adutra adutra commented Jan 30, 2026

This fix prevents test failures when catalogs have a table cache. This issue may arise e.g. with RESTCatalog since the recent introduction of RESTTableCache in 72d5fd6.

This fix prevents test failures when catalogs have a table cache. This issue may arise e.g. with `RESTCatalog` since the recent introduction of `RESTTableCache` in 72d5fd6.
@github-actions github-actions bot added the core label Jan 30, 2026
@pvary
Copy link
Contributor

pvary commented Jan 30, 2026

@adutra: Is this flaky? Or how can we not detect this issue during the tests there?

CC: @gaborkaszab

@adutra
Copy link
Contributor Author

adutra commented Jan 30, 2026

@pvary I don't think it's flaky, it's just that the issue will manifest only with a RESTCatalog that has caching by ETag enabled, which is not the case in TestRESTCatalog (but is the case in the Apache Polaris repo, that's where I spotted the issue).

@pvary
Copy link
Contributor

pvary commented Jan 30, 2026

@pvary I don't think it's flaky, it's just that the issue will manifest only with a RESTCatalog that has caching by ETag enabled, which is not the case in TestRESTCatalog (but is the case in the Apache Polaris repo, that's where I spotted the issue).

Shall we add a test which fails without the change? Otherwise what would prevent someone to break this again for Polaris?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants