IGNITE-27700 SQL Calcite: Fix merge filter to scan after trimmed fields #12675
Conversation
alex-plekhanov
force-pushed
the
ignite-27700
branch
from
ed62346 to
3c06571
Compare
.../java/org/apache/ignite/internal/processors/query/calcite/exec/exp/IgniteScalarFunction.java
Outdated
Show resolved
Hide resolved
| private IgniteScalarFunction(Method method, CallImplementor implementor, boolean deterministic) { | ||
| super(method, implementor); | ||
|
|
||
| this.deterministic = deterministic; |
There was a problem hiding this comment.
do we need mock? tests for such a case ? Can you exted java doc - what unexpected behavior will be raised if this flag missconfigured ?
There was a problem hiding this comment.
Test added.
What do you mean by the mock?
JavaDoc for public QuerySqlFunction annotation? I think it's already contains all required information. This annotation used for both query engines, so it's not correct to describe behavour for one of this engine in JavaDoc. Also this behavior can be extended later, for example if Calcite allow to change deterministic flag for SqlUserDefinedFunction class this flag will be processed also by Calcite and we can't control (and desrcibe on any change) all usages of this flag in Calcite code.
|
2 participants
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.