Skip to content

fix: update links in documentation for quick navigation#450

Merged
imbajin merged 3 commits intoapache:masterfrom
bitflicker64:fix-quickstart-links
Feb 9, 2026
Merged

fix: update links in documentation for quick navigation#450
imbajin merged 3 commits intoapache:masterfrom
bitflicker64:fix-quickstart-links

Conversation

@bitflicker64
Copy link
Contributor

Purpose of the PR

Fix broken Quick Start links on the documentation site.

Screen.Recording.Feb.9.2026.from.HugeGraph.mov
  • No related issue.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Feb 8, 2026
@imbajin
Copy link
Member

imbajin commented Feb 9, 2026

THX, please also check the https://github.com/apache/incubator-hugegraph-doc/blob/master/dist/validate-links.sh scrip (it should ensure/check the URL exists & valid BUT failed now)

@imbajin imbajin changed the title Update links in documentation for quick navigation fix: update links in documentation for quick navigation Feb 9, 2026
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 9, 2026
@bitflicker64
Copy link
Contributor Author

fixed more links and also
image

@imbajin
Copy link
Member

imbajin commented Feb 9, 2026

fixed more links and also image

@bitflicker64 Glad it passed locally. However, the fact that CI passed previously with broken links shows the script is flawed. We should make the check stricter so that any 404 links result in a CI failure.

https://github.com/apache/incubator-hugegraph-doc/blob/0d3b632c6894902e6afb6e5834c4a47c1df4baff/.github/workflows/hugo.yml#L44C33-L44C33

Refer: https://github.com/apache/incubator-hugegraph-doc/actions/runs/21623005341/job/62316158334 (Previous PR CI log)

@bitflicker64
Copy link
Contributor Author

bitflicker64 commented Feb 9, 2026

fixed more links and also image

@bitflicker64 Glad it passed locally. However, the fact that CI passed previously with broken links shows the script is flawed. We should make the check stricter so that any 404 links result in a CI failure.

https://github.com/apache/incubator-hugegraph-doc/blob/0d3b632c6894902e6afb6e5834c4a47c1df4baff/.github/workflows/hugo.yml#L44C33-L44C33

Refer: https://github.com/apache/incubator-hugegraph-doc/actions/runs/21623005341/job/62316158334 (Previous PR CI log)

That makes sense. This PR fixes the broken links, but they weren’t caught because validate-links.sh only checks a limited set of link patterns. I’ll open a separate PR to expand the validation so CI fails on these cases.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 9, 2026
@imbajin imbajin merged commit 486e0b8 into apache:master Feb 9, 2026
1 check passed
github-actions bot pushed a commit to Tsukilc/incubator-hugegraph-doc that referenced this pull request Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants