Skip to content

Ensure tests actually generate expected failures #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebbASF merged 1 commit into from
Jan 21, 2026
Merged

Ensure tests actually generate expected failures #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 11 additions & 18 deletions tests/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/usr/bin/env python3

import time
import re

import pytest
import quart
Expand All @@ -9,6 +10,10 @@
from asfquart.auth import Requirements as R


def _string_to_re(s):
"""convert arbitrary string to fullmatch regex"""
return re.escape(s) + '$'

@pytest.mark.auth
async def test_auth_basics():
app = asfquart.construct("foobar", token_file=None)
Expand All @@ -20,10 +25,8 @@ async def requires_session():

# Test with no session, should fail
quart.session = {}
try:
with pytest.raises(asfquart.auth.AuthenticationFailed, match=_string_to_re(R.E_NOT_LOGGED_IN)):
await requires_session()
except asfquart.auth.AuthenticationFailed as e:
assert e.message is R.E_NOT_LOGGED_IN

# Test with session, should work.
quart.session = {app.app_id: {"uts": time.time(), "foo": "bar"}}
Expand Down Expand Up @@ -53,17 +56,13 @@ async def requires_mfa():

# Test MFA with no session, should fail exactly like auth_required
quart.session = {}
try:
with pytest.raises(asfquart.auth.AuthenticationFailed, match=_string_to_re(R.E_NOT_LOGGED_IN)):
await requires_mfa()
except asfquart.auth.AuthenticationFailed as e:
assert e.message is R.E_NOT_LOGGED_IN

# Test with session without MFA, should fail.
quart.session = {app.app_id: {"uts": time.time(), "foo": "bar"}}
try:
with pytest.raises(asfquart.auth.AuthenticationFailed, match=_string_to_re(R.E_NO_MFA)):
await requires_mfa()
except asfquart.auth.AuthenticationFailed as e:
assert e.message is R.E_NO_MFA

# Test with session with MFA, should work.
quart.session = {app.app_id: {"uts": time.time(), "foo": "bar", "mfa": True}}
Expand Down Expand Up @@ -95,27 +94,21 @@ async def test_member_or_chair_auth():

# Test role with no session, should fail exactly like auth_required
quart.session = {}
try:
with pytest.raises(asfquart.auth.AuthenticationFailed, match=_string_to_re(R.E_NOT_LOGGED_IN)):
await test_committer_auth()
except asfquart.auth.AuthenticationFailed as e:
assert e.message is R.E_NOT_LOGGED_IN

# Test with session , should work
quart.session = {app.app_id: {"uts": time.time(), "foo": "bar"}}
await test_committer_auth()

# Test with a role we don't have, should fail
try:
with pytest.raises(asfquart.auth.AuthenticationFailed, match=_string_to_re(R.E_NOT_MEMBER)):
await test_member_auth()
except asfquart.auth.AuthenticationFailed as e:
assert e.message is R.E_NOT_MEMBER

# Test with for both member and chair, while only being member. should pass on member check, fail on chair
quart.session = {app.app_id: {"uts": time.time(), "foo": "bar", "isMember": True}}
try:
with pytest.raises(asfquart.auth.AuthenticationFailed, match=_string_to_re(R.E_NOT_CHAIR)):
await test_member_and_chair_auth()
except asfquart.auth.AuthenticationFailed as e:
assert e.message is R.E_NOT_CHAIR

# Test for either member of chair, should work as we have chair (but not member)
quart.session = {app.app_id: {"uts": time.time(), "foo": "bar", "isChair": True}}
Expand Down